fix(web): show skill group for casual scrims on home list (#662)#723
Merged
fix(web): show skill group for casual scrims on home list (#662)#723
Conversation
Pending scrim queries already return skillGroup; the table hid it unless competitive. Display the same label for casual scrims in the table and mobile card layout (fixes #662). Co-authored-by: Jake Bailey <asaxplayinghorse@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #662.
The pending scrims GraphQL payload already includes
skillGroup; the home list UI only rendered it whensettings.competitivewas true, so casual scrims showed an empty Skill Group column.Changes
ScrimTable.svelte: Always showscrim.skillGroup?.profile?.description(same data as after joining).ScrimCard.svelte: Add a Skill Group row for the mobile layout so narrow viewports match the table.Validation
npm run check --workspace=clients/web— fails with many pre-existing project errors; no new issues identified in the edited files beyond existingScrimTabletyping noise.Branch / commit
cursor/issue-662-casual-scrim-skill-group-0a5amain